fix: Use temp wav file on "Save As" for mp3 files

sillsdev / SpeechAnalyzer

SIL Speech Analyzer is a Windows program for acoustic analysis of speech sounds.

https://software.sil.org/speech-analyzer/

7 stars 3 forks source link

fix: Use temp wav file on "Save As" for mp3 files #54

Closed darcywong00 closed 2 years ago

darcywong00 commented 2 years ago

Fixes #49

Currently, when a user opens an mp3 file and attempts "Save As", the app is expecting a waveform file to already exist.

This PR updates the "Save As" File menu option to use the temporary waveform when an mp3 file is involved.

TODO

[x] more testing

darcywong00 commented 2 years ago

From @kgorham

@darcywong00 I tried your download link. Seemed to run fine. (uninstalled old SA and reinstalled new). As an improvement, I would suggest stealing some of the code that is in place already, and use the first part of the original filename for the new filename instead of using the .tmp filename. @terrygibbs can second that opinion or not...