search

sillsdev / SpeechAnalyzer

SIL Speech Analyzer is a Windows program for acoustic analysis of speech sounds.
https://software.sil.org/speech-analyzer/
7 stars 3 forks source link

bug: Use Project language code instead of Orthogrphic for Lift export #60

Closed darcywong00 closed 2 years ago

darcywong00 commented 2 years ago

Follow-on to #2 about SA Lift export to Flex

Per @terrygibbs

Orthographic typically isn't known early in an SA project. Maybe adjust to use the Ethnologue code in: Information --> Source --> Ethnologue ID field. If not defined, fall back to "und".

A future issue could add a line in the Lift Export dialog to mirror the Ethnologue ID field and maybe warn if undefined.

I note SA historically used the Orthographic field to build the lexical unit https://github.com/sillsdev/SpeechAnalyzer/blob/d1191aa6e158f1825994a804163fd77df6ae8da5/Src/SA/Sa_Doc.cpp#L7491

darcywong00 commented 2 years ago

After talking with @terrygibbs and Jennifer we decided

  1. If "orthographic" is defined, use it (since existing users may be using that)
  2. Fall back to the "Ethnologue ID" (3 character limit)
  3. Otherwise, use "und" for undefined.