search

sillsdev / SpeechAnalyzer

SIL Speech Analyzer is a Windows program for acoustic analysis of speech sounds.
https://software.sil.org/speech-analyzer/
7 stars 3 forks source link

chore: GA not supported in VS2022 since .NET 4.0 no longer included #64

Closed darcywong00 closed 2 years ago

darcywong00 commented 2 years ago

The GA builds are failing because the images are running with VS2022 now, which doesn't support .NET 4.0

I found other projects fix their CI builds by updating a .targets file with:

  <!-- 
    The global default value for target framework version seems to be v4.0.
    This is used in various places, but specifically used by the GetReferenceAssemblyPaths target in Microsoft.Common.CurrentVersion.Targets.
    The default version works with VS 2019 and lower, but it is not supported by VS 2022 and higher. This is causing pyproj files to break in VS2022.
    Therefore, we're overriding it to 4.7.2, which is supported.
  -->
  <PropertyGroup>
    <TargetFrameworkVersion>v4.7.2</TargetFrameworkVersion>
    <TargetFrameworkMoniker>.NETFramework,Version=$(TargetFrameworkVersion)</TargetFrameworkMoniker>
  </PropertyGroup>