search

sillsdev / SpeechAnalyzer

SIL Speech Analyzer is a Windows program for acoustic analysis of speech sounds.
https://software.sil.org/speech-analyzer/
7 stars 3 forks source link

fix: Use Ethnologue ID for creating IPA tags #65

Closed darcywong00 closed 2 years ago

darcywong00 commented 2 years ago

Fixes #60

For Lift exports, this updates the vernacular language to be defined based on what's available:

  1. orthographic field
  2. Ethnologue ID (3 letters. If blank, the code treats as 3 blank spaces " ")
  3. Fall back to "und" for undefined.

For students using projects that don't have orthographic defined, the legacy Ethnologue ID will be used to create the IPA tags.

megahirt commented 2 years ago

@darcywong00 for students wanting to match up with a Flex WS that contains a script or region, will this work? Is the field limited to 3 characters? I was expecting from our conversation to be able to put in e.g. en-US or th-LATN in the ethnologue ID field, since that we are highjacking that field for language tag use. In fact, I would suggest renaming the label to be "language tag".

darcywong00 commented 2 years ago

Is the field limited to 3 characters? I

Yes, the field is limited to 3 characters. The same "Ethnologue ID" field is also used for the "Export SFM" dialog (for the marker \\id).

Now that I've removed the extraneous "Fieldworks Project" dropdown, we do have space to maybe create a separate textfield for "language tag". This way, we don't stomp on SFM functionality.