Closed darcywong00 closed 2 years ago
Should it say "if orthographic unchecked"?
On Wed, Mar 2, 2022, 3:08 PM Darcy Wong @.***> wrote:
follow-on to #65 https://github.com/sillsdev/SpeechAnalyzer/pull/65 Since the "Ethnologue ID" is currently used for SFM Export, this adds an "optional language tag" to use in Lift exports when "Orthographic" is blank. This new text field is free-text (not limited to 3 characters as Ethnologue ID is), so the user/student will need to be guided on a proper BCP 47 tag to use.
To recap, the project language of the Lift export will use (in order of what's defined)
- Orthographic
- Optional language tag
- und for undefined
Screenshot of the updated [image: new export] https://user-images.githubusercontent.com/7358010/156320744-53027f7c-09c6-4aec-b34e-4b5647cb275b.png dialog
You can view, comment on, or merge this pull request online at:
https://github.com/sillsdev/SpeechAnalyzer/pull/68 Commit Summary
- bfabdf9 https://github.com/sillsdev/SpeechAnalyzer/pull/68/commits/bfabdf92d35f9b1f948c93b9ceb75d8868b46df3 fix: Add optional language tag for Lift export
File Changes
(6 files https://github.com/sillsdev/SpeechAnalyzer/pull/68/files)
- M Src/Lang/SA_DEU.rc https://github.com/sillsdev/SpeechAnalyzer/pull/68/files#diff-a6a68cc41d51366667fd473e5e0ee01e81efb6dfb6f626260f7e8a759574280f (8)
- M Src/Lang/SA_ENU.rc https://github.com/sillsdev/SpeechAnalyzer/pull/68/files#diff-e64e53d72452136b23d8bf78690c7a4b3250047f02e2fbe164ad2ecf1999fdcf (14)
- M Src/Lang/sa_lang_resource.h https://github.com/sillsdev/SpeechAnalyzer/pull/68/files#diff-221522ae66bff247f4d7ca864aced11ef29ab0dd1320cf15d45aa19235be67b6 (2)
- M Src/SA/DlgExportLift.cpp https://github.com/sillsdev/SpeechAnalyzer/pull/68/files#diff-57e09934789751c9aa286a3b948be2202c7eff0797bfbe825dcaee7069797b66 (1)
- M Src/SA/ExportLiftSettings.h https://github.com/sillsdev/SpeechAnalyzer/pull/68/files#diff-70546e0f1c6608af947607a64a2c2968f2b80d6ea5c2b17e4d90f9a1713dec06 (1)
- M Src/SA/Sa_Doc.cpp https://github.com/sillsdev/SpeechAnalyzer/pull/68/files#diff-d3a0ddb4ab3b88ed98028004bdc621bac3c1afdbf4c38cb765454b14d7713d5d (6)
Patch Links:
- https://github.com/sillsdev/SpeechAnalyzer/pull/68.patch
- https://github.com/sillsdev/SpeechAnalyzer/pull/68.diff
— Reply to this email directly, view it on GitHub https://github.com/sillsdev/SpeechAnalyzer/pull/68, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2I6KLJ4CIG7FRR5R4OUS3U54OZJANCNFSM5PWTYTBA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
follow-on to #65 Since the "Ethnologue ID" is currently used for SFM Export, this adds an "optional language tag" to use in Lift exports when "Orthographic" is blank. This new text field is free-text (not limited to 3 characters as Ethnologue ID is), so the user/student will need to be guided on a proper BCP 47 tag to use.
To recap, the project language of the Lift export will use (in order of what's defined)
und
for undefinedScreenshot of the updated dialog