sillsdev / SpeechAnalyzer

SIL Speech Analyzer is a Windows program for acoustic analysis of speech sounds.
https://software.sil.org/speech-analyzer/
7 stars 3 forks source link

fix: Add optional language tag for Lift export #68

Closed darcywong00 closed 2 years ago

darcywong00 commented 2 years ago

follow-on to #65 Since the "Ethnologue ID" is currently used for SFM Export, this adds an "optional language tag" to use in Lift exports when "Orthographic" is blank. This new text field is free-text (not limited to 3 characters as Ethnologue ID is), so the user/student will need to be guided on a proper BCP 47 tag to use.

To recap, the project language of the Lift export will use (in order of what's defined)

  1. Orthographic
  2. Optional language tag
  3. und for undefined

Screenshot of the updated dialog new export

megahirt commented 2 years ago

Should it say "if orthographic unchecked"?

On Wed, Mar 2, 2022, 3:08 PM Darcy Wong @.***> wrote:

follow-on to #65 https://github.com/sillsdev/SpeechAnalyzer/pull/65 Since the "Ethnologue ID" is currently used for SFM Export, this adds an "optional language tag" to use in Lift exports when "Orthographic" is blank. This new text field is free-text (not limited to 3 characters as Ethnologue ID is), so the user/student will need to be guided on a proper BCP 47 tag to use.

To recap, the project language of the Lift export will use (in order of what's defined)

  1. Orthographic
  2. Optional language tag
  3. und for undefined

Screenshot of the updated [image: new export] https://user-images.githubusercontent.com/7358010/156320744-53027f7c-09c6-4aec-b34e-4b5647cb275b.png dialog

You can view, comment on, or merge this pull request online at:

https://github.com/sillsdev/SpeechAnalyzer/pull/68 Commit Summary

File Changes

(6 files https://github.com/sillsdev/SpeechAnalyzer/pull/68/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/sillsdev/SpeechAnalyzer/pull/68, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2I6KLJ4CIG7FRR5R4OUS3U54OZJANCNFSM5PWTYTBA . You are receiving this because you are subscribed to this thread.Message ID: @.***>