sillsdev / TheCombine

This is a tool for supporting the rapid word collection workshop and post workshop clean-up
https://sillsdev.github.io/TheCombine/
MIT License
16 stars 13 forks source link

Round-trip DATA LOSS from fields TheCombine doesn't use/export. #1750

Open MattGyverLee opened 2 years ago

MattGyverLee commented 2 years ago

When Exporting to LIFT from FLEx, all filled standard and custom fields are exported with each entry. When Exporting the same Dictionary from TheCombine, only a subset of fields are exported (lexeme, gloss, etc).

For entries that were unedited, the date stamp doesn't change, so the data doesn't get lost.

For merged senses, only gloss and SemDom fields are maintained. Grammatical Category and any other previously-filled fields are LOST in the merge. As long as this bug exists, people with existing dictionaries containg more than lexeme, gloss, and SemDom (any field not exported by TC) should NOT use TheCombine.

To Reproduce

Steps to reproduce the behavior:

  1. Import any LIFT database from FLEx with data more complex than lexeme, sense, semantic domain.
  2. Merge duplicates.
  3. Export to LIFT from TheCombine.
  4. Examine the LIFT and notice that most fields are not maintained.
  5. Import into a test copy of FLEx, and notice that senses that get merged lose data such as Grammatical category.

Expected behavior

All unchanged imported data should round-trip FLEx Lift>TheCombine>FLEx. Extra fields on merged senses should be merged and not be lost.

Environment:

MattGyverLee commented 2 years ago

Lexeme form, Gloss, and Semantic Domain are the only fields that are maintained on import/export.

Everything else is lost: Citation form, Pronunciation, Definition, and all custom fields.

jasonleenaylor commented 1 year ago

After #1761 we think this is not an issue but will verify the following: