search

sillsdev / TheCombine

This is a tool for supporting the rapid word collection workshop and post workshop clean-up
https://sillsdev.github.io/TheCombine/
MIT License
17 stars 13 forks source link

[ReviewEntries] Turn off return-to-first-page-when-row-is-edited #3158

Closed imnasnainaec closed 1 month ago

imnasnainaec commented 1 month ago

Fixes #3147

Disable autoResetPageIndex (https://www.material-react-table.com/docs/guides/pagination#customize-pagination-behavior), which resets the table to the first page when editing/filtering/sorting. (It would be nice to have the latter two, but not at the expense of the first one.)

This change is Reviewable

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.98%. Comparing base (6302b3c) to head (e683692).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3158 +/- ## ========================================== - Coverage 75.02% 74.98% -0.04% ========================================== Files 271 271 Lines 10394 10394 Branches 1230 1230 ========================================== - Hits 7798 7794 -4 - Misses 2237 2240 +3 - Partials 359 360 +1 ``` | [Flag](https://app.codecov.io/gh/sillsdev/TheCombine/pull/3158/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sillsdev) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/sillsdev/TheCombine/pull/3158/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sillsdev) | `83.96% <ø> (-0.09%)` | :arrow_down: | | [frontend](https://app.codecov.io/gh/sillsdev/TheCombine/pull/3158/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sillsdev) | `66.83% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sillsdev#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

imnasnainaec commented 1 month ago

Opened discussion about separating functionality for editing and for filtering/sorting: https://github.com/KevinVandy/material-react-table/discussions/1157