sillsdev / TheCombine

This is a tool for supporting the rapid word collection workshop and post workshop clean-up
https://sillsdev.github.io/TheCombine/
MIT License
16 stars 13 forks source link

Only disable page-index-reset for edits #3160

Closed imnasnainaec closed 1 month ago

imnasnainaec commented 3 months ago

A more nuanced follow-up to #3158, which rightly prevented a reset of the current page index when a row is edited. A sad byproduct was that the table no longer jumps back to the first page when column filters/sorts are applied or changed. This pr restores that preferred behavior.


This change is Reviewable

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.57%. Comparing base (fa18e58) to head (65ae0b9). Report is 34 commits behind head on master.

Files with missing lines Patch % Lines
...c/goals/ReviewEntries/ReviewEntriesTable/index.tsx 33.33% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3160 +/- ## ========================================== + Coverage 74.55% 74.57% +0.01% ========================================== Files 279 279 Lines 10687 10694 +7 Branches 1288 1288 ========================================== + Hits 7968 7975 +7 + Misses 2355 2354 -1 - Partials 364 365 +1 ``` | [Flag](https://app.codecov.io/gh/sillsdev/TheCombine/pull/3160/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sillsdev) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/sillsdev/TheCombine/pull/3160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sillsdev) | `83.79% <ø> (ø)` | | | [frontend](https://app.codecov.io/gh/sillsdev/TheCombine/pull/3160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sillsdev) | `66.49% <33.33%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sillsdev#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.