sillsdev / TheCombine

This is a tool for supporting the rapid word collection workshop and post workshop clean-up
https://sillsdev.github.io/TheCombine/
MIT License
17 stars 13 forks source link

Remove unnecessary `[FromForm]` baggage and fix axios issue #3176

Closed imnasnainaec closed 1 week ago

imnasnainaec commented 1 week ago

Resolves #1930


This change is Reviewable

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.14%. Comparing base (e8a7106) to head (7f66031).

Files Patch % Lines
Backend/Controllers/LiftController.cs 33.33% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3176 +/- ## ========================================== + Coverage 75.10% 75.14% +0.04% ========================================== Files 275 275 Lines 10423 10414 -9 Branches 1230 1231 +1 ========================================== - Hits 7828 7826 -2 + Misses 2235 2231 -4 + Partials 360 357 -3 ``` | [Flag](https://app.codecov.io/gh/sillsdev/TheCombine/pull/3176/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sillsdev) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/sillsdev/TheCombine/pull/3176/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sillsdev) | `84.26% <69.23%> (+0.11%)` | :arrow_up: | | [frontend](https://app.codecov.io/gh/sillsdev/TheCombine/pull/3176/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sillsdev) | `66.96% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sillsdev#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.