search

sillsdev / TheCombine

This is a tool for supporting the rapid word collection workshop and post workshop clean-up
https://sillsdev.github.io/TheCombine/
MIT License
17 stars 13 forks source link

Run `npm update` #3179

Closed imnasnainaec closed 6 days ago

imnasnainaec commented 1 week ago

This change is Reviewable

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.17%. Comparing base (551bfe7) to head (2d39a5e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3179 +/- ## ========================================== + Coverage 75.12% 75.17% +0.04% ========================================== Files 275 275 Lines 10431 10431 Branches 1237 1237 ========================================== + Hits 7836 7841 +5 + Misses 2236 2232 -4 + Partials 359 358 -1 ``` | [Flag](https://app.codecov.io/gh/sillsdev/TheCombine/pull/3179/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sillsdev) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/sillsdev/TheCombine/pull/3179/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sillsdev) | `84.24% <ø> (+0.10%)` | :arrow_up: | | [frontend](https://app.codecov.io/gh/sillsdev/TheCombine/pull/3179/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sillsdev) | `67.05% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sillsdev#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jasonleenaylor commented 1 week ago

src/components/TreeView/TreeDepiction/tests/__snapshots__/index.test.tsx.snap line 4156 at r2 (raw file):

      >
        <button
          className="MuiButtonBase-root MuiButton-root MuiButton-outlined MuiButton-outlinedPrimary MuiButton-sizeMedium MuiButton-outlinedSizeMedium MuiButton-colorPrimary MuiButton-root MuiButton-outlined MuiButton-outlinedPrimary MuiButton-sizeMedium MuiButton-outlinedSizeMedium MuiButton-colorPrimary css-1rwt2y5-MuiButtonBase-root-MuiButton-root"

Just verifying that these test snapshots don't actually indicate an unexpected color change

imnasnainaec commented 6 days ago

Reviewed 19 of 19 files at r2, all commit messages. Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

Affirmative. Just did a side-by-side visual check to be sure.