search

sillsdev / TheCombine

This is a tool for supporting the rapid word collection workshop and post workshop clean-up
https://sillsdev.github.io/TheCombine/
MIT License
17 stars 13 forks source link

Retract #3161 due to broken placement styles #3188

Closed imnasnainaec closed 6 days ago

imnasnainaec commented 1 week ago

3161 used sx color functions with no regard for different size/margin/placement handling between style and sx. As a consequence, the announcement banner and the loading button spinning wheel (and possibly other things) were way out of place:

Screenshot 2024-06-28 144047

This change is Reviewable

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.13%. Comparing base (2e5d278) to head (4753f08).

Files Patch % Lines
src/components/ProjectExport/DownloadButton.tsx 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3188 +/- ## ========================================== + Coverage 75.11% 75.13% +0.02% ========================================== Files 275 275 Lines 10422 10413 -9 Branches 1232 1231 -1 ========================================== - Hits 7828 7824 -4 + Misses 2236 2231 -5 Partials 358 358 ``` | [Flag](https://app.codecov.io/gh/sillsdev/TheCombine/pull/3188/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sillsdev) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/sillsdev/TheCombine/pull/3188/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sillsdev) | `84.24% <ø> (+0.06%)` | :arrow_up: | | [frontend](https://app.codecov.io/gh/sillsdev/TheCombine/pull/3188/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sillsdev) | `66.96% <66.66%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sillsdev#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.