sillsdev / TheCombine

This is a tool for supporting the rapid word collection workshop and post workshop clean-up
https://sillsdev.github.io/TheCombine/
MIT License
17 stars 13 forks source link

Update TS target to ES6 (which we already use) #3232

Closed imnasnainaec closed 1 week ago

imnasnainaec commented 2 weeks ago

We're already using ES6 features (e.g., arrow functions and let/const), so this change just helps the IDE know what Typescript syntax is allowable.

Before this change, my IDE was complaining about the use of the /u RegEx ending in src/utilities/spellChecker.ts.


This change is Reviewable

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.81%. Comparing base (ea679bb) to head (a355a1f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3232 +/- ## ========================================== - Coverage 74.84% 74.81% -0.04% ========================================== Files 277 277 Lines 10636 10636 Branches 1276 1276 ========================================== - Hits 7961 7957 -4 - Misses 2312 2316 +4 Partials 363 363 ``` | [Flag](https://app.codecov.io/gh/sillsdev/TheCombine/pull/3232/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sillsdev) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/sillsdev/TheCombine/pull/3232/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sillsdev) | `83.94% <ø> (-0.09%)` | :arrow_down: | | [frontend](https://app.codecov.io/gh/sillsdev/TheCombine/pull/3232/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sillsdev) | `66.74% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sillsdev#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.