search

sillsdev / appbuilder-pwa

Progress Web App template for Scripture App Builder
https://software.sil.org/scriptureappbuilder
MIT License
8 stars 22 forks source link

Hide empty verses option #494

Open davidmoore1 opened 2 months ago

davidmoore1 commented 2 months ago

If a verse is empty, don't display the verse number if the "Hide empty verses" option is selected in SAB formatting section. It currently displays like this (and should display like this when the Hide empty verses option is not selected.

Screenshot 2024-05-08 at 8 26 02 AM

Example usfm \p \v 15 ”Ar be-mimmide, Bab-Dummad-asabin dule-dummadga guoed. Vino gobosulid, degi, inna-gagbid gobosurbalid. Degine, amba muu-neggi mai, bato Bab-Dummad-Burba-Isligwaled bela-bela nika guoed. \v 16 \v 17 Ar be-mimmi-Juan, Elíasʼyobi Dule-Dummad-idu-nadapi guoed. Deyob Bab-Dummad-Burba, degi, Bab-Dummad-gangued-nika guoed. Adi, babgan gannar na e-mimmiganbina itogerba guega, degi, dule-galagwensuli-gudimaladi dule-nueganga imakega, binsaed-nikaa damalaga, degi, guagwar dulemar-urbega, adi, Bab-Dummad-abingamalagar.” \p

davidmoore1 commented 2 months ago

This shows how it should appear with the option selected: Simulator Screenshot - iPhone 12 - 2024-05-08 at 08 31 42

chrisvire commented 2 months ago

The easiest way to implement this might be to add a process in convertBooks that after the data is loaded check for empty verses, and delete them using gql.