search

sillsdev / appbuilder-pwa

Progress Web App template for Scripture App Builder
https://software.sil.org/scriptureappbuilder
MIT License
8 stars 26 forks source link

Play video included in assets #600

Closed davidmoore1 closed 2 months ago

davidmoore1 commented 3 months ago

A reference to a video that is included in the assets is in the SAB PWA Test app at CUK Luke 11: 27

The html that is generated for the Android app is as follows: Screenshot 2024-06-10 at 4 13 05 PM

The reference in the appDef file is:

    <video id="V1" src="a1" width="320" height="192">
      <filename>Blessed-are-those-Who-Hear-and-Obey.mp4</filename>
      <thumbnail>V20190816085348972.jpg</thumbnail>
      <placement pos="before" ref="CUKNVS|LUK.11.28"/>
    </video>

There are probably multiple issues that are preventing this from displaying properly. The first is that the ConvertConfig method, where it processes video tags, is not saving the filename entry into the config.js file.

From there, the Html being generated for this entry needs to be changed to correctly play the file. The current online video may possibly be used as a reference or perhaps just generate html for this kind of entry similar to what the Android app does.