Always write timestamps with time zones

sillsdev / chorus

End-user collaboration library via 3-way xml merging and hg dvcs under the hood

6 stars 26 forks source link

Always write timestamps with time zones #160

Closed rmunn closed 6 years ago

rmunn commented 6 years ago

This is PR #125, but merging into master to make sure the bug stays fixed in future versions of Chorus.

This change is

ermshiperete commented 6 years ago

Reviewed 3 of 8 files at r2, 5 of 5 files at r3. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

jasonleenaylor commented 6 years ago

I am willing to accept this change now. I didn't realize this was still waiting. Here is one other thing worth considering: It seems to me that it could actually be better to always store the date as UTC in the file. This would make it easier to investigate timing things at the xml level.