search

sillsdev / chorus

End-user collaboration library via 3-way xml merging and hg dvcs under the hood
6 stars 26 forks source link

Add Microsoft.NET.Test.Sdk to test projects #296

Closed ermshiperete closed 1 year ago

ermshiperete commented 1 year ago

According to the docs^1 it is recommended to add Microsoft.NET.Test.Sdk to all projects so that the tests can be discovered in VS.

Also add NUnit3TestAdapter to all test projects which is now required^2 and remove NUnit from Tests-ChorusPlugin where it's not used.

This change is Reviewable

github-actions[bot] commented 1 year ago

Test Results

       8 files  +    6     239 suites  +39   45m 36s :stopwatch: + 3m 21s    972 tests +102     917 :heavy_check_mark: +  67    55 :zzz: +36  0 :x:  - 1  2 198 runs  +210  2 079 :heavy_check_mark: +135  119 :zzz: +76  0 :x:  - 1 

Results for commit d1db2d2c. ± Comparison against base commit 8a713080.

:recycle: This comment has been updated with latest results.

ermshiperete commented 1 year ago

This change now causes more tests to be detected, some of these require UI and thus fail.

ermshiperete commented 1 year ago

The failing test will likely be fixed by #295.