Net6launch

[josephmyers]

This change is 

[github-actions[bot]]

Test Results

     10 files  +       2     443 suites  +204   1h 26m 28s :stopwatch: + 40m 49s    973 tests +       1     917 :heavy_check_mark: ±       0    56 :zzz: +    1  0 :x: ±0  4 190 runs  +1 992  3 966 :heavy_check_mark: +1 887  224 :zzz: +105  0 :x: ±0 

Results for commit 37e6d0b9. ± Comparison against base commit 9549415e.

This pull request skips 1 test.

``` ExternalFileModification_NotifiesIndices_ButSaveDoesNot ```

:recycle: This comment has been updated with latest results.

[josephmyers]

I'm not sure what's going with the latest changes to dotnet.yml, but they're causing the windows tests (net461) to hang. Before, the command was run: dotnet test -- NUnit.TestOutputXml=TestResults, but now that it's run: dotnet test --no-build -c Release --filter TestCategory!=SkipOnBuildServer -- NUnit.TestOutputXml=TestResults, it hangs during a test.

Here's a snippet from a test run without --no-build:

  Skipped LaunchDialog_SimulatedUsb_USBHasInvalidRepo
  Skipped ShowIt
  Skipped LaunchDialog_CustomAddress
  Skipped LaunchDialog_FullAddress
Warning: Killing Hg Process...

    Syncing...
    Started at 2022-09-20 03:55:53Z
    Local User: bob
    LanguageForge User: 

But with it, it hangs after Skipped LaunchDialog_FullAddress.

Unfortunately, removing --no-build avoids the hang, but now ChorusMerge.Tests fail and LibChorus.Tests are skipped. Ideas, anyone?

[ermshiperete]

Do you know which tests hang? Did you try to ignore (for the purpose of tracking down the problem) the new HgMergeTests to see if that makes a difference?

[josephmyers]

Even with a diagnostic test run, the current test being run isn't printed (lol), but I figured it out and have the fix pushed. It was related to some Encoding call required for .NET6 but breaking for Framework.

The tests take longer to finish, now that we're running LibChorus on .NET6 as well. I think it's worth it, but I'm open to whatever.