sillsdev / chorus

End-user collaboration library via 3-way xml merging and hg dvcs under the hood
6 stars 26 forks source link

increase audio and picture file size limit to 10MB #301

Closed megahirt closed 1 year ago

megahirt commented 1 year ago

Fixes #277

This is in response to users who report a need to add audio and pictures to their project over 1MB in FLEx and Language Forge. The 1MB is reported to be too small.

Because we don't know practically how this will impact the majority of users, I am happy to introduce this change and evaluate the impact (pluses and minuses) on Language Forge and FLEx users who use Language Depot to collaborate, as well as the increased server storage needed to accommodate the higher limits.


This change is Reviewable

github-actions[bot] commented 1 year ago

Test Results

       4 files  ±0     119 suites  ±0   27m 53s :stopwatch: - 1m 52s    954 tests ±0     860 :heavy_check_mark:  - 3  79 :zzz: ±0  15 :x: +3  1 100 runs  ±0  1 005 :heavy_check_mark:  - 4  79 :zzz: ±0  16 :x: +4 

For more details on these failures, see this check.

Results for commit d368d78b. ± Comparison against base commit 327aa7e3.

:recycle: This comment has been updated with latest results.

megahirt commented 1 year ago

Hi @papeh, I'm confused about the workflow in this PR. It says that the PR was merged with failing unit tests (why was it merged?) but then the commit was later reverted "until unit tests can be fixed". Does this mean that the change is no longer in master?