search

sillsdev / chorus

End-user collaboration library via 3-way xml merging and hg dvcs under the hood
6 stars 26 forks source link

Reorder Custom URL outside Language Forge workflow #304

Closed papeh closed 1 year ago

papeh commented 1 year ago

And comment on the use of .languageforge.org

Part of https://jira.sil.org/browse/LT-21209

This change is Reviewable

github-actions[bot] commented 1 year ago

Test Results

       4 files   -        2     119 suites   - 202   28m 3s :stopwatch: - 28m 19s    954 tests  -        2     863 :heavy_check_mark:  -      34  79 :zzz: +20  12 :x: +12  1 100 runs   - 1 990  1 009 :heavy_check_mark:  - 1 933  79 :zzz:  - 69  12 :x: +12 

For more details on these failures, see this check.

Results for commit 526f9cd1. ± Comparison against base commit 26502478.

This pull request removes 2 tests. ``` ExternalFileModification_NotifiesIndices_ButSaveDoesNot SaveAndLoad_10KRecords_CompletesQuickly ```
This pull request skips 20 tests. ``` AddAndCheckinFile_WLockExists_GetTimeoutException Commit_WLockExists_GetTimeoutException EncryptPassword_NullAndEmptyDoNotCrash EncryptPassword_RoundTrips GetIsReadyForInternetSendReceive_HasFullLangForgeUrlAndSavedCredentials_ReturnsTrue InitFromUri_NoUsernameOrPass_UsesSettings InitFromUri_UsernameAndPass_OverwritesSettings KnownHandlers_ContainsHandlersFromChorusExe PasswordForSession_UsesSaved("") PasswordForSession_UsesSaved("myPass") … ```

:recycle: This comment has been updated with latest results.

bobeaton commented 1 year ago

Is the custom url approach being retired bkz we can now log into the private language forge server also?

Bob

From: papeh @.> Sent: Tuesday, November 29, 2022 4:48 PM To: sillsdev/chorus @.> Cc: Subscribed @.***> Subject: [sillsdev/chorus] Remove Custom URL from Language Forge workflow (PR #304)

EXTERNAL EMAIL

CAUTION: This email originated from outside your organization. Exercise caution when opening attachments or clicking links, especially from unknown senders.

Unsure so far whether it should go at the top or the bottom.

Part of https://jira.sil.org/browse/LT-21209

This change is [Reviewable]https://reviewable.io/reviews/sillsdev/chorus/304

You can view, comment on, or merge this pull request online at:

https://github.com/sillsdev/chorus/pull/304

Commit Summary

File Changes

(14 fileshttps://github.com/sillsdev/chorus/pull/304/files)

Patch Links:

— Reply to this email directly, view it on GitHubhttps://github.com/sillsdev/chorus/pull/304, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABDUY5NYNZLYC5ACSF3NGH3WK2BYRANCNFSM6AAAAAASO73R64. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

This message and its contents are intended only for the person or entity to which it is addressed. It may contain confidential and/or protected material. Any review, transmission, dissemination or other use of this information by anyone other than the intended recipient is strictly prohibited. If you are not the intended recipient, please notify the sender by replying to this message and then delete it from your system. Thank you.

papeh commented 1 year ago

Is the custom url approach being retired bkz we can now log into the private language forge server also?

Sorry, my original title was misleading. Presently, the Custom URL checkbox is between the username and password boxes and the Log in button for Language Depot. This change will move the Custom URL control out from between the Language Depot login controls. We think >1% of users use their own servers, so we want this as out-of-the-way as possible.

It is possible to use the standard controls for private.languageforge.org by setting the static bool ServerSettingsModel.IsPrivateServer = true, but last I checked, we are still waiting for server-side changes before users can log in and see their projects, so we're not validating their credentials when they click Log in.