sillsdev / chorus

End-user collaboration library via 3-way xml merging and hg dvcs under the hood
6 stars 26 forks source link

Update the EnricoMi/publish-unit-test-result-action, fix tests #308

Closed jasonleenaylor closed 1 year ago

jasonleenaylor commented 1 year ago

This change is Reviewable

github-actions[bot] commented 1 year ago

Test Results

       6 files  +       2     321 suites  +202   58m 6s :stopwatch: + 28m 5s    957 tests +       3     898 :heavy_check_mark: +     38    59 :zzz:  - 20  0 :x:  - 15  3 090 runs  +1 990  2 942 :heavy_check_mark: +1 937  148 :zzz: +69  0 :x:  - 16 

Results for commit 428f2e06. ± Comparison against base commit aa17de8b.

This pull request removes 2 and adds 5 tests. Note that renamed tests count towards both. ``` CreateWithInstalledHandlers_DefaulthandlerIsNotInMainCollection CreateWithTestHandlerOnly_DefaulthandlerIsNotInTestCollection ``` ``` CreateWithInstalledHandlers_DefaultHandlerIsNotInMainCollection CreateWithTestHandlerOnly_DefaultHandlerIsNotInTestCollection ExternalFileModification_NotifiesIndices_ButSaveDoesNot HandlerShouldProcessOnlyTenMegabyteSizedFiles SaveAndLoad_10KRecords_CompletesQuickly ```

:recycle: This comment has been updated with latest results.

jasonleenaylor commented 1 year ago

src/LibChorus/notes/EmbeddedMessageContentHandlerRepository.cs line 42 at r2 (raw file):

          //Set the codebase variable appropriately depending on the OS
          var codeBase = libChorusAssembly.Location.Substring(Platform.IsUnix ? 7 : 8);
          var baseDir = Path.GetDirectoryName(codeBase);

var baseDir = Path.GetDirectoryName(libChorusAssembly.Location);

Code quote:

            var codeBase = libChorusAssembly.Location.Substring(Platform.IsUnix ? 7 : 8);
            var baseDir = Path.GetDirectoryName(codeBase);
papeh commented 1 year ago

Fix Unit Tests

papeh commented 1 year ago

included in #307