sillsdev / chorus

End-user collaboration library via 3-way xml merging and hg dvcs under the hood
6 stars 26 forks source link

Allow special characters in credentials (LT-20157, LT-21275) #316

Closed papeh closed 1 year ago

papeh commented 1 year ago

Escape credentials used in URLs

Some users use their email addresses as their logins. When we overhauled the Get from Internet UX, we inadvertently stopped escaping credentials.

Addresses https://jira.sil.org/browse/LT-20157 and https://jira.sil.org/browse/LT-21275


This change is Reviewable

github-actions[bot] commented 1 year ago

Test Results

       6 files  ±0     321 suites  ±0   58m 25s :stopwatch: + 2m 9s    959 tests +2     900 :heavy_check_mark: +  2    59 :zzz: ±0  0 :x: ±0  3 096 runs  +6  2 954 :heavy_check_mark: +12  142 :zzz:  - 6  0 :x: ±0 

Results for commit 7d5a73c2. ± Comparison against base commit 95476085.

This pull request removes 2 and adds 4 tests. Note that renamed tests count towards both. ``` GetUserName_NameInLocalReopHasSpace_GetsName GetUserName_NameInLocalReop_GetsName ``` ``` GetPotentialRepoUri_InsertsEscapedCredentials GetUserName_NameInLocalRepoHasSpace_GetsName GetUserName_NameInLocalRepo_GetsName RemovePasswordForLog_RemovesTheEscapedPassword ```

:recycle: This comment has been updated with latest results.