search

sillsdev / chorus

End-user collaboration library via 3-way xml merging and hg dvcs under the hood
6 stars 26 forks source link

Add webm as audio-file-type so it gets 10MB limit #319

Closed myieye closed 1 year ago

myieye commented 1 year ago

We recently increased the max file size for audio and images to 10MB.

But webm is a significant file format in the browser (i.e. Language Forge) and it's not included in the list of known audio file types, so recording audio in LF never actually benefited from this previous change 😲😢,

Webm is a file-type that FLEx supports, so there's no obvious reason to me why we shouldn't include it here, it was simply forgotten. image

This change is Reviewable

github-actions[bot] commented 1 year ago

Test Results

       2 files  ±0     202 suites  ±0   43m 49s :stopwatch: +37s    874 tests ±0     852 :heavy_check_mark: ±0  22 :zzz: ±0  0 :x: ±0  1 994 runs  ±0  1 929 :heavy_check_mark: ±0  65 :zzz: ±0  0 :x: ±0 

Results for commit a18a11fa. ± Comparison against base commit fa4a8c6a.

hahn-kev commented 1 year ago

one reason that webm might have not been included is that FLEx doesn't support it in all cases. There's some cases where a webm file is encoded using PCM audio (by the browser) and that encoding isn't supported as a webm file in FLEx. Because of this issue in the Combine we decided to convert webm files to wav when they were exported to FLEx. We might run into the same issue here where files will now get exported properly, and FLEx will see them, but still can't play them.

myieye commented 1 year ago

@hahn-kev Interesting. Well, you could already send webm files to FLEx before this change. They just reverted to the default file size limit. All I did was increase the file size limit for them.