Closed myieye closed 1 year ago
βββββββ2 filesβ Β±0βββββ202 suitesβ Β±0βββ43m 49s :stopwatch: +37s βββ874 tests Β±0βββββ852 :heavy_check_mark: Β±0ββ22 :zzz: Β±0ββ0 :x: Β±0β 1β994 runsβ Β±0ββ1β929 :heavy_check_mark: Β±0ββ65 :zzz: Β±0ββ0 :x: Β±0β
Results for commit a18a11fa.βΒ± Comparison against base commit fa4a8c6a.
one reason that webm might have not been included is that FLEx doesn't support it in all cases. There's some cases where a webm file is encoded using PCM audio (by the browser) and that encoding isn't supported as a webm file in FLEx. Because of this issue in the Combine we decided to convert webm files to wav when they were exported to FLEx. We might run into the same issue here where files will now get exported properly, and FLEx will see them, but still can't play them.
@hahn-kev Interesting. Well, you could already send webm files to FLEx before this change. They just reverted to the default file size limit. All I did was increase the file size limit for them.
We recently increased the max file size for audio and images to 10MB.
But webm is a significant file format in the browser (i.e. Language Forge) and it's not included in the list of known audio file types, so recording audio in LF never actually benefited from this previous change π²π’,
Webm is a file-type that FLEx supports, so there's no obvious reason to me why we shouldn't include it here, it was simply forgotten.![image](https://github.com/sillsdev/chorus/assets/12587509/42da21f6-a450-4309-8ec5-6d9279cd5386)
This change isβ![Reviewable](https://reviewable.io/review_button.svg)