sillsdev / chorus

End-user collaboration library via 3-way xml merging and hg dvcs under the hood
6 stars 26 forks source link

remove usage of BinaryFormatter #328

Closed hahn-kev closed 1 year ago

hahn-kev commented 1 year ago

closes #327 transition to json serialization. Refactor Revision.cs to support serialization, Revision has a public surface area so it may effect other applications using Chorus.

Previously Revision had a private field storing an HgRepository class, it's not clear to me if that was just left null when it was read back out but I've resolved that by removing it completely, now anyone calling a method that used to depend on that field will have to provide the repository itself.


This change is Reviewable

github-actions[bot] commented 1 year ago

Test Results

       2 files  ±0     202 suites  ±0   43m 14s :stopwatch: -1s    876 tests +1     854 :heavy_check_mark: +1  22 :zzz: ±0  0 :x: ±0  1 998 runs  +2  1 932 :heavy_check_mark: +2  66 :zzz: ±0  0 :x: ±0 

Results for commit a51e777d. ± Comparison against base commit dc230d52.

:recycle: This comment has been updated with latest results.

hahn-kev commented 1 year ago

@ermshiperete done, thanks for the suggestion and helping me with the workflow.