Closed rmunn closed 4 months ago
4 files ±0 412 suites ±0 2h 46m 4s :stopwatch: +8s 881 tests ±0 858 :heavy_check_mark: ±0 23 :zzz: ±0 0 :x: ±0 4 032 runs ±0 3 898 :heavy_check_mark: ±0 134 :zzz: ±0 0 :x: ±0
Results for commit cec33501. ± Comparison against base commit ccdf57d9.
Fixes #337.
Most code paths use ServerSettingsModel.RemovePasswordForLog to replace the user's Send/Receive password with a string of asterisks, but there was one code path where this was missed. This PR fixes that omission. It is also extra-cautious trying to make sure that the debug logging doesn't throw exceptions: if simply calling RemovePasswordForLog ends up throwing an exception somehow, instead of returning the unmodified URI (which might still have a password in it), we simply do not log the URI. This might be over-cautious, but it's probably better to be safe.
This change is![Reviewable](https://reviewable.io/review_button.svg)