search

sillsdev / chorus

End-user collaboration library via 3-way xml merging and hg dvcs under the hood
6 stars 26 forks source link

change languagedepot.org url to lexbox.org #342

Open hahn-kev opened 5 months ago

hahn-kev commented 5 months ago

this will change the domain used in the dialog, but we also want to change any pre existing projects. This will require hooking this ini check code https://github.com/sillsdev/chorus/blob/104ce40716ad38b52e0794a1bdddf2891ca73d7a/src/LibChorus/VcsDrivers/Mercurial/HgRepository.cs#L155-L176 if the domain is Ld then change it to lexbox. Be careful to make sure it's not changing the domain in other cases.

I'd also like to try and change how the protocol logic works so we can drop all the domains except lexbox. This will require changing https://github.com/sillsdev/chorus/blob/7504501e0dfb15ee733924960e19da1f674625f4/src/LibChorus/VcsDrivers/RepositoryAddress.cs#L108-L114 and any code that calls it to use a stored value of what protocol to use for a project (or it might be global?).

For HG It will also require changing the assumption that the url is https:://{host}/{projectId} to https:://{host}/hg/{projectId} (project id being the chorus term, lexbox calls it project code) https://github.com/sillsdev/chorus/blob/80bee2fd6f5e19bcd648d941c6969a5dbacf1cbf/src/LibChorus/Model/ServerSettingsModel.cs#L127 and https://github.com/sillsdev/chorus/blob/80bee2fd6f5e19bcd648d941c6969a5dbacf1cbf/src/LibChorus/Model/ServerSettingsModel.cs#L149 though there may be other places.

josephmyers commented 5 months ago

Am I supposed to be assigned to this?

hahn-kev commented 5 months ago

I probably should have just mentioned you, but I wanted you to be aware if you had the time to spend on it.