sillsdev / chorus

End-user collaboration library via 3-way xml merging and hg dvcs under the hood
6 stars 26 forks source link

Don't duplicate stdout and stderr in verbose progress output #345

Closed rmunn closed 2 months ago

rmunn commented 3 months ago

HgRepository.GetTextFromQuery calls ExecuteErrorsOk, then prints the contents of stdout and stderr via progress.WriteVerbose if they aren't empty. However, ExecuteErrorsOk also prints stdout and stderr with progress.WriteVerbose if they aren't empty. This duplication does nothing but make it harder to find things in the Chorus output, and I suggest getting rid of the progress.WriteVerbose calls from HgRepository.GetTextFromQuery.