search

sillsdev / chorus

End-user collaboration library via 3-way xml merging and hg dvcs under the hood
6 stars 26 forks source link

Don't duplicate hg process output in GetTextFromQuery #347

Closed rmunn closed 2 months ago

rmunn commented 2 months ago

Fixes #345.

GetTextFromQuery calls ExecuteErrorsOk, which already logs the value of stdout and stderr to the progress dialog. So there's no point in logging the same value a second time.

This change is Reviewable

rmunn commented 2 months ago

PR is on top of #346 in order to avoid merge conflicts once #346 is merged into master.

github-actions[bot] commented 2 months ago

Test Results

       4 files  ±0     412 suites  ±0   2h 45m 49s :stopwatch: -8s    883 tests ±0     860 :heavy_check_mark: ±0    23 :zzz: ±0  0 :x: ±0  4 040 runs  ±0  3 906 :heavy_check_mark: ±0  134 :zzz: ±0  0 :x: ±0 

Results for commit 7a649c60. ± Comparison against base commit 41c3d974.