search

sillsdev / chorus

End-user collaboration library via 3-way xml merging and hg dvcs under the hood
6 stars 26 forks source link

No more unnecessary empty "stderr:" lines in log #349

Closed rmunn closed 2 months ago

rmunn commented 3 months ago

Many times stderr's contents are just a single newline; there's no need to write that to the progress log. We also don't need to write double newlines to the log, so trim the final trailing newline before writing.

Fixes #348.

This change is Reviewable

rmunn commented 3 months ago

PR created on top of #347 to avoid merge conflicts once #347 is merged to master.

github-actions[bot] commented 2 months ago

Test Results

       4 files  ±0     412 suites  ±0   2h 46m 44s :stopwatch: +57s    883 tests ±0     860 :heavy_check_mark: ±0    23 :zzz: ±0  0 :x: ±0  4 040 runs  ±0  3 906 :heavy_check_mark: ±0  134 :zzz: ±0  0 :x: ±0 

Results for commit 33c812a6. ± Comparison against base commit 4535fc4b.