sillsdev / flashgrid

Other
5 stars 4 forks source link

Fix table and table cell sizes #10

Closed pconstrictor closed 9 years ago

pconstrictor commented 9 years ago

The main issue here is that the grid cells are not of equal size horizontally.

The second is that the table does not expand vertically to fill its window, so there is often too much white space below it. NOTE: we probably don't want to generate a table with an explicit size to make it fill the window, Rather, we want it to auto expand/contract on resize.

pconstrictor commented 9 years ago

Mostly fixed, for columns anyway. Rows are a bit trickier to resize, so I just tried to make them at least take up most of the screen. The 3x3 grid looks a lot better now too.

Here's the relevant code, to be refined further: html, body, table { height:580px; table-layout:fixed} /* 100% height doesn't appear to work; 'fixed' gives equal column widths */

pconstrictor commented 9 years ago

Further improved balance, and set max-image-sizes more precisely. But resizing still only works for the columns; the row heights are still specified in pixels, though now that's computed based on current screen resolution.