Closed imnasnainaec closed 4 months ago
5 files ±0 403 suites ±0 5s :stopwatch: -1s 431 tests ±0 427 :heavy_check_mark: ±0 4 :zzz: ±0 0 :x: ±0 2 193 runs ±0 2 095 :heavy_check_mark: ±0 98 :zzz: ±0 0 :x: ±0
Results for commit 41370224. ± Comparison against base commit fddc930f.
:recycle: This comment has been updated with latest results.
Looks good to me. The overall question about "how do we know that NativeLibrary will be functionally compatible with the previous approach for Windows and Linux users on .NET 6.0 or later?" is still there, but I don't see anything in these changes that looks like a regression or a problem.
I'll try to test it out more.
For reference, here's the code NativeLibrary
uses: for Unix; for Windows
For Unix, it uses [LibraryImport(Interop.Libraries.SystemNative, EntryPoint = "SystemNative_LoadLibrary", StringMarshalling = StringMarshalling.Utf8)]
(in Interop.Sys)
@lyonsil Yeah, I was having similar concerns, so I left this in draft until it could be given more thorough consideration.