sillsdev / l10nsharp

A .NET localization library for Windows Forms applications.
3 stars 10 forks source link

Add `LocalizationManager.Create` methods without `kind` parameter #107

Closed ermshiperete closed 1 year ago

ermshiperete commented 1 year ago

Also deprecate existing Create methods with kind parameter.

Since Xliff is now the only supported translation memory, the kind parameter is unnecessary. This change adds new overloads without the kind parameter and marks the existing methods as Obsolete.

+semver:minor


This change is Reviewable

github-actions[bot] commented 1 year ago

Test Results

    1 files   -     1    23 suites   - 21   6s :stopwatch: -7s 148 tests ±    0  143 :heavy_check_mark: ±    0  5 :zzz: ±0  0 :x: ±0  148 runs   - 148  143 :heavy_check_mark:  - 145  5 :zzz:  - 3  0 :x: ±0 

Results for commit 06098c27. ± Comparison against base commit b0d02528.

:recycle: This comment has been updated with latest results.

tombogle commented 1 year ago

There's a TestFixture that runs a set of tests for each type of storage. I'm guessing that removing the kind parameter affects how that test works.