sillsdev / l10nsharp

A .NET localization library for Windows Forms applications.
3 stars 10 forks source link

Added IncludeSourceRevisionInInformationalVersion to SampleApp so Version doesn't get added garbage #117

Open tombogle opened 7 months ago

tombogle commented 7 months ago

Added some test code to the sample app to try to re-create and diagnose problem the Bloom team encountered.


This change is Reviewable

github-actions[bot] commented 7 months ago

Test Results

    3 files  ±0    84 suites  ±0   16s :stopwatch: -1s 165 tests ±0  160 :heavy_check_mark: ±0    5 :zzz: ±0  0 :x: ±0  495 runs  ±0  480 :heavy_check_mark: ±0  15 :zzz: ±0  0 :x: ±0 

Results for commit e326deec. ± Comparison against base commit f0bbbd9a.

:recycle: This comment has been updated with latest results.

tombogle commented 3 weeks ago

I guess that is mostly true. But since we do have the StrictInitializationMode property, I've made it so the SampleApp can properly test the behavior when that is set to false and also (bit more subtly) demonstrate the expected behavior when true.