search

sillsdev / languageforge-lexbox

Lexbox, SIL linguistic data hub
MIT License
7 stars 2 forks source link

Make FixFwData do real work #1155

Open rmunn opened 2 hours ago

rmunn commented 2 hours ago

Describe the feature Until now, our copy of FixFwData has done nothing. But there's real fixups that might need to be applied, usually as a result of a merge conflict. The copy of FixFwData from LfMerge is a good model to copy from: it sets up some basic logging and then calls the FwDataFixer class from SIL.LCModel.Utils to do the actual work.

Until now the LexBox code has only done S/R as part of our testing, so a do-nothing FixFwData didn't matter. But once CrdtMerge gets deployed, it will be doing S/R on real projects, so we will need FixFwData to do real work as well.

rmunn commented 2 hours ago

This shouldn't take long as I can mostly copy the LfMerge implementation, though I'll use ConsoleProgress from SIL.Core rather than implement a custom LoggingProgress that just reinvents the SIL.Core wheel. So I'm rating the size of this task as Small.