Always project and cache project confidentiality

sillsdev / languageforge-lexbox

Lexbox, SIL linguistic data hub

MIT License

7 stars 2 forks source link

Always project and cache project confidentiality #1198

Closed myieye closed 2 weeks ago

myieye commented 3 weeks ago

TL;DR

Improved project confidentiality caching and permission checks for project member visibility.

What changed?

Added a new ProjectConfidentialityCachingMiddleware to manage project confidentiality state
Refined permissions checks to prioritize confidentiality lookups over other async checks, because it's now likely cheaper

Why make this change?

To reduce db hits

myieye commented 3 weeks ago

#1198 👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @myieye and the rest of your teammates on Graphite

github-actions[bot] commented 3 weeks ago

UI unit Tests

12 tests ±0 12 :white_check_mark: ±0 0s :stopwatch: ±0s 4 suites ±0 0 :zzz: ±0 1 files ±0 0 :x: ±0

Results for commit 34434b18. ± Comparison against base commit e83930d2.

github-actions[bot] commented 3 weeks ago

C# Unit Tests

75 tests ±0 75 :white_check_mark: ±0 5s :stopwatch: ±0s 13 suites ±0 0 :zzz: ±0 1 files ±0 0 :x: ±0

Results for commit 34434b18. ± Comparison against base commit e83930d2.

myieye commented 3 weeks ago

@hahn-kev I'm really second guessing whether this is worth it. It's even possible that doing this in the middleware is actually too late, because a permission check in the current request already queried it. An EF Core interceptor would be a better place.

I know this was my idea, but my current opinion is that we should ditch it 😆.

What do you think?