Change 'bool CanSyncProject' to 'bool IsProjectMember' - Githubissues

sillsdev / languageforge-lexbox

Lexbox, SIL linguistic data hub

MIT License

7 stars 2 forks source link

Change 'bool CanSyncProject' to 'bool IsProjectMember' #1235

Closed myieye closed 6 days ago

myieye commented 1 week ago

So, I didn't remove LexAuthUser.IsProjectMember like I said I would. LexAuthUser seems like a nice place for that.

But I think this refactor makes the PermissionService API less confusing.

The old bool CanSyncProject and the new bool IsProjectMember are not equivalent. But there were only 2 places that use bool CanSyncProject and only 1 needed adapting.

I also found a place where I had forgotten to pass an overrideUser.
I removed the comments from IPermissionService, because they're not necessary now that the API is more intuitive.

github-actions[bot] commented 1 week ago

C# Unit Tests

90 tests ±0 90 :white_check_mark: ±0 5s :stopwatch: ±0s 14 suites ±0 0 :zzz: ±0 1 files ±0 0 :x: ±0

Results for commit ab548ecb. ± Comparison against base commit 0fcb7ad7.