search

sillsdev / languageforge-lexbox

Lexbox, SIL linguistic data hub
MIT License
7 stars 2 forks source link

Implement new update API for writing systems #1240

Open rmunn opened 1 week ago

rmunn commented 1 week ago

Fix #1189.

Note that FwDataMiniLcmApi hasn't implemented the UpdateWritingSystem overload with (id, type, update), which the (before, after) method is going to end up calling. So that still needs to happen.

rmunn commented 3 days ago

Decision during yesterday's team meeting: for now, Font will remain a single string and will be used to indicate the default font in LCM (DefaultFontName property). DefaultFontName is read-only in LCM, so if it changes on the CRDT side, we should instead use its new value to look up the name of a font and set the DefaultFont property in LCM, e.g.:

ws.DefaultFont = new FontDefinition("Charis SIL");