Do not throw exceptions for empty model number

sillsdev / languageforge-lexbox

Lexbox, SIL linguistic data hub

MIT License

7 stars 2 forks source link

Do not throw exceptions for empty model number #1243

Closed rmunn closed 6 days ago

rmunn commented 1 week ago

Fix #1242.

If a project is empty, the FLEx model version command returns an empty string. HgService.GetModelVersionOfFlexProject should not throw an exception in such cases, but simply return null meaning "can't find the FLEx model".

github-actions[bot] commented 1 week ago

C# Unit Tests

90 tests ±0 90 :white_check_mark: ±0 5s :stopwatch: ±0s 14 suites ±0 0 :zzz: ±0 1 files ±0 0 :x: ±0

Results for commit fd3d2174. ± Comparison against base commit 10a107f1.

:recycle: This comment has been updated with latest results.

hahn-kev commented 6 days ago

feel free to ignore that test failure and merge, I've seen it on other PRs and it's been fixed in develop