search

sillsdev / languageforge-lexbox

Lexbox, SIL linguistic data hub
MIT License
7 stars 2 forks source link

Migrate everything from Shouldly to FluentAssertions #1262

Open myieye opened 1 day ago

myieye commented 1 day ago

Migrates all our assertion from Shouldy to FluentAssertions as decided at our team meeting.

This should get User typeahead enabled for non-admin project managers unstuck.

~Questionable:~ ~- I created created custom assertions (e.g. ShouldNotBeNull()) as we discussed, but I put the class right in the Testing namespace~ ~- I added a project reference from MiniLcm.Tests to Testing so it gets the custom assertions~ ~- Adding that reference resulted in some package version differences that I resolved by updating them~

EDIT: I just updated to a FluentAssertions 7 prerelease and they solved the problem for us.

github-actions[bot] commented 1 day ago

C# Unit Tests

90 tests   90 :white_check_mark:  5s :stopwatch: 14 suites   0 :zzz:  1 files     0 :x:

Results for commit bbd1064e.

:recycle: This comment has been updated with latest results.