search

sillsdev / languageforge-lexbox

Lexbox, SIL linguistic data hub
MIT License
7 stars 2 forks source link

Make DraftProject.IsConfidential NonNullable #737

Open myieye opened 5 months ago

myieye commented 5 months ago

This is an issue for code debt that hasn't even been merged yet 😆.

DraftProject.IsConfidential sort of needs to be nullable initially, because we don't want existing drafts to just revert to the default when they're created/approved.

After: 1) We've deployed #254 2) Processed all the drafts that existed before that

We should be able to make DraftProject.IsConfidential NonNullable.

⚠️ Also look for any occurences of TODO #737's in the code base.

rmunn commented 5 months ago

⚠️ Also look for any occurences of TODO #737's in the code base.

TODO 737: Make sure the door plug bolts are put back.

(It's a Boeing joke).

rmunn commented 5 months ago

Just a note to say that the property is now named IsConfidential rather than IsSensitive.