search

sillsdev / libpalaso

Palaso Library: A set of .Net libraries useful for developers of Language Software.
MIT License
44 stars 51 forks source link

(auto publish l10n; auto download l10n) #1286

Closed papeh closed 11 months ago

papeh commented 11 months ago

This change is Reviewable

tombogle commented 11 months ago

DistFiles/Palaso.en.xlf line 5 at r1 (raw file):

  <file source-language="en" product-version="12.0.1" original="Palaso.dll" datatype="plaintext">
    <body>
      <trans-unit id="AboutDialog.BuiltOnDate">

Might be worth a little more explanation in the readme file as to why this empty shell is needed. (I'm guessing the only useful thing it actually supplies is the "original" attribute, right?

tombogle commented 11 months ago

.gitignore line 45 at r2 (raw file):

/SIL.Windows.Forms/bin-Designer/**
launchSettings.json
DistFiles/*.xlf

If there are no .xlf files checked in anywhere, maybe it would be best to just have *.xlf

tombogle commented 11 months ago

SIL.Core.Tests/CommandLineProcessing/CommandLineRunnerTests.cs line 55 at r3 (raw file):

          var bldr = new StringBuilder();
          CommandLineRunner.Run(App, "CommandLineRunnerTest", null, string.Empty, 100,
              progress, s => bldr.AppendLine($"{++linesReceivedAsynchronously}: '{s}'"), null, true);

Does this actually succeed on Linux now?

tombogle commented 11 months ago

TestApps/SIL.Windows.Forms.TestApp/Program.cs line 41 at r3 (raw file):

              else
              {
                  // Test command-line runner's ability to read console output and time out.

I really don't understand what is being tested here. Maybe a more robust comment is in order. Since you're now doing this before the LM is created, if the timeout happens, is there an error dialog or error message that appears that we might have wanted to be displayed in French?

tombogle commented 11 months ago

DistFiles/Palaso.en.xlf line 5 at r1 (raw file):

Previously, papeh wrote…
You mean Palaso.en.xlf? I tested, and that's not required for the app to run in English on Windows. I haven't tested on Linux.

Oops. Looks like I never finished writing that sentence. I was going to (and now have) check to see how the code worked. It looks like l10n.proj does correctly specify the extension in the -o parameter when calling ExtractXliff, so everything should be fine.