search

sillsdev / libpalaso

Palaso Library: A set of .Net libraries useful for developers of Language Software.
MIT License
44 stars 51 forks source link

fix l10n.proj #1291

Closed papeh closed 10 months ago

papeh commented 11 months ago

This change is Reviewable

papeh commented 11 months ago

😲 Just discovered that each run will add another <note xml:lang="en">Not found in static scan of compiled code (version 0.0.0)</note> to each applicable string. We should implement a cleanup step.

🏁Update: done.

tombogle commented 10 months ago

l10n/l10n.proj line 41 at r2 (raw file):


  <Target Name="UpdateCrowdinInternal" DependsOnTargets="GetVersion">
  <!-- Remove "not found" messages that are appended each run (Can't MatchWholeLine because leading spaces are trimmed from Lines) -->

I know those lines are just informative. Are we removing them because they cause problems or are they actually incorrect? Maybe the comment could be made a little more verbose to explain why we are removing them.