search

sillsdev / libpalaso

Palaso Library: A set of .Net libraries useful for developers of Language Software.
MIT License
44 stars 51 forks source link

LT-21652: polish picture dialog #1301

Closed aror92 closed 10 months ago

aror92 commented 10 months ago

Use the custom no border toolstrip renderer to eliminate the white border artifact in AquireImageControl. (Other part of LT-21652.)

Also set toolStrip1's RenderMode to Professional and reset back color to control from within the design view, which regenerated the designer & resx files.

This change is Reviewable

andrew-polk commented 10 months ago

What was the reason for changing the tab selection indicator?

Before: image

After: image

Also, this change didn't get an entry in the change log.

andrew-polk commented 10 months ago

@jasonleenaylor Seems like UI changes deserve a little more fanfare before merging?

jasonleenaylor commented 10 months ago

@andrew-polk Hello, sorry about that. I thought you all had stopped using this. The intended UI change was only to remove the ugly line artifact. I didn't give it adequate review.

andrew-polk commented 10 months ago

Thanks. Yeah, we're still using it for now. We've done some work on a react replacement, but it hasn't shipped yet.