Renamed project to SIL.Windows.Forms.Archiving

[josephmyers]

This change is 

[tombogle]

Palaso.sln line 30 at r1 (raw file):

Previously, tombogle (Tom Bogle) wrote…

Now I'm wondering if we should actually be trying to split this stuff into Forms vs. non-Forms DLLs. None of the unit tests depend on WinForms, so all the classes they are testing could be in a non-Forms dependent DLL. I'm not sure if they do anything useful enough on their own to warrant this though.

Looking at the code, the ArchivingDlg classes (abstract base and two concrete implementations) are the only things that really need to depend on WinForms. The models do, but only minimally and in a way they really shouldn't. If we were to fix those design issues, then those models could be used to back a non WinForms implementation.

[josephmyers]

@tombogle, any chance we'll see progress here this week or next?

[tombogle]

Not sure when I'll be able to get to this.

[josephmyers]

I discovered today that SIL.Media is a WinForms project. So a bit more to come on this

[megahirt]

I discovered today that SIL.Media is a WinForms project. So a bit more to come on this

@josephmyers we can rename SIL.Media in a separate PR.

[josephmyers]

I discovered today that SIL.Media is a WinForms project. So a bit more to come on this

@josephmyers we can rename SIL.Media in a separate PR.

1325

[tombogle]

I'm doing some fixing in this area currently, so this might actually be a good time for me to try to break it into two parts. Give me a couple days, and if I can't, then we'll go ahead and merge as is.

[github-actions[bot]]

LibPalaso Tests

   17 files  ±0     17 suites  ±0   9m 34s :stopwatch: - 2m 50s 4 890 tests +6  4 659 :white_check_mark: +6  231 :zzz: ±0  0 :x: ±0  4 909 runs  +6  4 665 :white_check_mark: +6  244 :zzz: ±0  0 :x: ±0 

Results for commit 67b1ecd1. ± Comparison against base commit d85edaa5.

This pull request removes 54 and adds 60 tests. Note that renamed tests count towards both.

``` SIL.Archiving.Tests.RampArchivingDlgViewModelTests ‑ GetMode_FwbackupFileWithMultipleTypesInList_ReturnsCorrectMetsList SIL.Windows.Forms.Tests.ClearShare.ContributionTests ‑ AreContentsEqual_AllSame_ReturnsTrue SIL.Windows.Forms.Tests.ClearShare.ContributionTests ‑ AreContentsEqual_DatesDifferent_ReturnsFalse SIL.Windows.Forms.Tests.ClearShare.ContributionTests ‑ AreContentsEqual_LicensesDifferent_ReturnsFalse SIL.Windows.Forms.Tests.ClearShare.ContributionTests ‑ AreContentsEqual_NamesDifferent_ReturnsFalse SIL.Windows.Forms.Tests.ClearShare.ContributionTests ‑ AreContentsEqual_NotesDifferent_ReturnsFalse SIL.Windows.Forms.Tests.ClearShare.ContributionTests ‑ AreContentsEqual_OtherIsNull_ReturnsFalse SIL.Windows.Forms.Tests.ClearShare.ContributionTests ‑ AreContentsEqual_RolesDifferent_ReturnsFalse SIL.Windows.Forms.Tests.ClearShare.ContributionTests ‑ Clone_ReturnsDifferentNonNullObject SIL.Windows.Forms.Tests.ClearShare.ContributionTests ‑ Clone_ReturnsSameContent … ``` ``` SIL.Archiving.Tests.ArchivingLanguageTests ‑ Compare_DifferentCodeOrLanguageName_ReturnsNonZero("eng","English","frg","Froggish") SIL.Archiving.Tests.ArchivingLanguageTests ‑ Compare_DifferentCodeOrLanguageName_ReturnsNonZero("som","Some Language","unk","Some Language") SIL.Archiving.Tests.ArchivingLanguageTests ‑ Compare_DifferentCodeOrLanguageName_ReturnsNonZero("zzz","Zyzzyvian","zzz","Scrabbilian") SIL.Archiving.Tests.ArchivingLanguageTests ‑ Compare_SameCodeAndLanguageName_ReturnsZero SIL.Archiving.Tests.LanguageListTests ‑ FindByEnglishName_ExistingLanguage_GetsExpectedNameCodeAndId("English","eng") SIL.Archiving.Tests.LanguageListTests ‑ FindByISO3Code_ExistingLanguageWithNoOtherName_GetsExpectedNameCodeAndId("eng","English") SIL.Archiving.Tests.RampArchivingDlgViewModelTests ‑ GetMode_FwBackupFileWithMultipleTypesInList_ReturnsCorrectMetsList SIL.Tests.ClearShare.ContributionTests ‑ AreContentsEqual_AllSame_ReturnsTrue SIL.Tests.ClearShare.ContributionTests ‑ AreContentsEqual_DatesDifferent_ReturnsFalse SIL.Tests.ClearShare.ContributionTests ‑ AreContentsEqual_LicensesDifferent_ReturnsFalse … ```

:recycle: This comment has been updated with latest results.

[tombogle]

I have completed my work on splitting this into two DLLs. Ready for review.

[tombogle]

Palaso.sln line 30 at r1 (raw file):

Previously, megahirt (Christopher Hirt) wrote…

@tombogle how about we just leave this PR as a simple rename and if you'd like to circle back on a refactor that you can do that in a separate PR? I'd like to get this merged.

No longer relevant

[tombogle]

What sort of issues?

[tombogle]

Never mind. I see there are some github comments that Reviewable knows nothing about.