search

sillsdev / libpalaso

Palaso Library: A set of .Net libraries useful for developers of Language Software.
MIT License
44 stars 51 forks source link

Fixed backwards logic for LocalizationIncompleteViewModel.ShouldShowDialog #1318

Closed tombogle closed 4 months ago

tombogle commented 4 months ago

(Technically this is a breaking contractual change, since effectively the behavior is the opposite of the original implementation, but the name so clearly indicates the desired behavior that it seems unlikely any subclass implementation would have implemented the logic according to the previously expected backwards behavior.)

This change is Reviewable

tombogle commented 4 months ago

When this is merged and released and Transcelerator gets it, there is a TODO in the Transcelerator code to fix the implementation to work correctly.