sillsdev / machine.py

Machine is a natural language processing library for Python that is focused on providing tools for processing resource-poor languages.
MIT License
10 stars 2 forks source link

Fixed off-by-one errors in _create_word_graph #77

Closed isaac091 closed 11 months ago

isaac091 commented 11 months ago

The source_start_index and source_end_index of WordGraphArcs seem to be 1-indexed, which was leading to index out of range errors.


This change is Reviewable

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (96a6786) 86.74% compared to head (c67806b) 86.84%. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #77 +/- ## ========================================== + Coverage 86.74% 86.84% +0.09% ========================================== Files 226 226 Lines 13596 13606 +10 ========================================== + Hits 11794 11816 +22 + Misses 1802 1790 -12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.