Closed johnml1135 closed 6 months ago
src/SIL.Machine/Corpora/UsfmTextUpdater.cs
line 29 at r1 (raw file):
I would make the default `false`, since that is the current behavior.
Done.
src/SIL.Machine/Corpora/UsfmTextUpdater.cs
line 363 at r1 (raw file):
I wouldn't use `Skip` here. It is not very efficient when operating on a list. It will iterate through the list instead of jumping to the specified index.
OK - reworked algorithm.
tests/SIL.Machine.Tests/Corpora/UsfmTextUpdaterTests.cs
line 53 at r1 (raw file):
I would rename this test, maybe `GetUsfm_PreferRows`.
done
src/AssemblyInfo.props
line 3 at r3 (raw file):
Please update the version in a separate PR, especially not in a PR that has already been approved. Update the version to 3.1.1. There isn't enough of a change to warrant a new minor release.
ok
Attention: Patch coverage is 96.77419%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 67.12%. Comparing base (
7b05b93
) to head (a30c2a9
).
Files | Patch % | Lines |
---|---|---|
src/SIL.Machine/Corpora/UsfmTextUpdater.cs | 96.49% | 1 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
https://github.com/sillsdev/serval/issues/370
Reworked the logic of preferring existing or new text.
This change is