search

sillsdev / machine

Machine is a natural language processing library for .NET that is focused on providing tools for processing resource-poor languages.
MIT License
26 stars 15 forks source link

Usfm parse error logging #191

Closed johnml1135 closed 4 months ago

johnml1135 commented 4 months ago

Fixes: https://github.com/sillsdev/serval/issues/376 https://github.com/sillsdev/serval/issues/375

This change is Reviewable

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.15%. Comparing base (321c6e7) to head (067b83d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #191 +/- ## ========================================== + Coverage 67.12% 67.15% +0.02% ========================================== Files 441 441 Lines 34890 34890 Branches 4672 4672 ========================================== + Hits 23421 23430 +9 + Misses 10376 10368 -8 + Partials 1093 1092 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

johnml1135 commented 4 months ago

src/SIL.Machine/Corpora/UsfmFileText.cs line 48 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…
I don't believe that this will fix the issue. The crash is occurring in `UsfmZipText`. Also, this is not generic enough, since the file name in a PT project is configurable. We should use the file naming setting in the PT project settings to determine how to properly parse the file name. I think we should wait until we get more information before we submit a fix for this issue.

Fine enough - I reverted the fix. The other work is more important for today.