Closed Enkidu93 closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.33%. Comparing base (
8d84ddd
) to head (24d17f3
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixes https://github.com/sillsdev/serval/issues/284
A couple questions regarding the solution:
OperationCanceledException
when the engine doesn't exist inNmtPreprocessBuildJob
. Is that what we want? Or should this throw some other exception that would cause the build to be marked as failed instead? And if so, should it also do the same in this case? Maybe I'm missing something.HangfireBuildJob
code:if (!await BuildJobService.BuildJobStartedAsync(engineId, buildId, cancellationToken)) { completionStatus = JobCompletionStatus.Canceled; return; }
What am I missing?This change is