sillsdev / machine

Machine is a natural language processing library for .NET that is focused on providing tools for processing resource-poor languages.
MIT License
26 stars 15 forks source link

Fixes https://github.com/sillsdev/serval/issues/449 #232

Closed Enkidu93 closed 2 months ago

Enkidu93 commented 2 months ago

I'm not sure that this is the cleanest solution, but it does resolve the issue. Please critique :)


This change is Reviewable

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.66%. Comparing base (e97df8c) to head (6f34aa0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #232 +/- ## ======================================= Coverage 69.66% 69.66% ======================================= Files 377 377 Lines 31374 31377 +3 Branches 4391 4391 ======================================= + Hits 21856 21860 +4 Misses 8498 8498 + Partials 1020 1019 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

johnml1135 commented 2 months ago

tests/SIL.Machine.Tests/Corpora/UsfmMemoryTextTests.cs line 117 at r1 (raw file):

    public void GetRows_OptBreak()
    {
        // a verse paragraph that begins with a non-verse segment followed by a verse segment

Non verse followed by verse? Isn't it the other way around?

Enkidu93 commented 2 months ago

That works, @ddaspit . I saw that function but dismissed it because of the naming.

johnml1135 commented 2 months ago

Aside from outbreaks not being documented as part of USFM, it looks great.

johnml1135 commented 2 months ago
:lgtm: