sillsdev / ptx2pdf

XeTeX based macro package for typesetting USFM formatted (Paratext output) scripture files
21 stars 7 forks source link

Spacing Bug for Marginal Verses #926

Closed RCraigWebb closed 5 months ago

RCraigWebb commented 8 months ago

Hello PTXPrint,

I've been working on formatting for marginal verses and when I click on Advanced/Misc Refinement Settings and change the After Verse Space Factor it works well on regular verse numbers but doesn't adjust the verse bridges. I've been changing the default setting of 0.15 to 0.30 to increase the spacing from 1mm to 1.5mm and noticed the numbers aren't lining up anymore. If I set it back to the default the numbers are in line again. This is with Paratext project KHT in the book of Mat with \versehyphentrue added in the mods. Let me know if you want me to send examples and/or the Paratext files.

Marginal verses are looking much better than they did before. I know this is low priority for most of the world so I appreciate your work.

Craig

mhosken commented 8 months ago

I'm not sure I understand the problem, do a couple of close ups of 1mm and 1.5mm will help me see what you are seeing.

On Wed, 8 Nov 2023, 09:02 RCraigWebb, @.***> wrote:

Hello PTXPrint,

I've been working on formatting for marginal verses and when I click on Advanced/Misc Refinement Settings and change the After Verse Space Factor it works well on regular verse numbers but doesn't adjust the verse bridges. I've been changing the default setting of 0.15 to 0.30 to increase the spacing from 1mm to 1.5mm and noticed the numbers aren't lining up anymore. If I set it back to the default the numbers are in line again. This is with Paratext project KHT in the book of Mat with \versehyphentrue added in the mods. Let me know if you want me to send examples and/or the Paratext files.

Marginal verses are looking much better than they did before. I know this is low priority for most of the world so I appreciate your work.

Craig

— Reply to this email directly, view it on GitHub https://github.com/sillsdev/ptx2pdf/issues/926, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLMO3O74XTM4KHIL7YO6U3YDNDDVAVCNFSM6AAAAAA7CQJDF6VHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4DGMBYG4YDENA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

RCraigWebb commented 8 months ago

Hello Martin,

Here are two files, the 15 is the default setting and all verse numbers are aligned. The 30 is with the adjustment and the single verse numbers are adjusted correctly and the verse bridges are still in the same place as with the default setting.

Low priority but when you get time. Craig

RCraigWebb commented 8 months ago

Top screenshot is default setting or .15 and bottom is adjusted to .30 Default of 15 Setting at 30

mhosken commented 8 months ago

I think the increased space after the verse has meant that the overall space taken up by a bridge plus the space after the verse number is greater than the space allocation for marginal verses and so the bridged verses push in towards the text. Try increasing the space allocation for marginal verses.

On Wed, 8 Nov 2023, 09:48 RCraigWebb, @.***> wrote:

[image: Default of 15] https://user-images.githubusercontent.com/140577140/281351899-05808384-9df2-407f-9850-1318d6f2078a.png [image: Setting at 30] https://user-images.githubusercontent.com/140577140/281351931-5704522a-b2e2-4964-9f03-a3ab6916d498.png Here are screenshots

— Reply to this email directly, view it on GitHub https://github.com/sillsdev/ptx2pdf/issues/926#issuecomment-1801451116, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLMO3OVXKTV6LZWULP3XF3YDNIP7AVCNFSM6AAAAAA7CQJDF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBRGQ2TCMJRGY . You are receiving this because you commented.Message ID: @.***>

markpenny commented 7 months ago

@RCraigWebb Did @mhosken's suggestion solve this issue? If so, please go ahead and close the issue. If not, we will have to dig further for a solution.